Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add envFrom ConfigMap to chart #518

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

luanaBanana
Copy link
Contributor

This adds the support to add envFrom with configMapRef through Helm Values:

I wasn't able to use an array of maps with the current setup, like this:

  chaoskube:
    env:
      - name: MY_VAR
        valueFrom:
          configMapKeyRef:
            name: chaoskube-cm1
            key: my-var

Results in: error converting YAML to JSON: yaml: line 39: did not find expected key

With this PR it will be possible to add the following:

  chaoskube:
    envFromConfigMapRefs:
       - chaoskube-cm1
       - chaoskube-cm2

What do you think, could this be merged?

@linki linki merged commit bc3c6ba into linki:master Jan 4, 2023
@linki
Copy link
Owner

linki commented Jan 4, 2023

@luanaBanana Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants