Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to test with upstream linkml #316

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Mar 25, 2024

Fix: linkml/linkml#1749

This PR adds an action to run the linkml tests against the current version of linkml-runtime.

This action runs after an approving review has been received, and can also be run manually. This is because this is a relatively expensive test, and should only be run after the content of a PR has been approved to check whether any modifications will need to be made upstream to accommodate it.

If this is accepted, in order for it to be protective we probably need to also add a branch protection rule that prevents pull requests from being merged until this action has passed. otherwise the temptation might be to approve a PR and then immediately merge it, since the action will run only then.

As with all github actions things, i am actually not sure it will do exactly what i think it will until i see it run, so this might require a little debugging, but anyway it should help out with the perennial need to manually run linkml tests against linkml-runtime and make it a bit easier for this repo to be developed safely

differences from linkml main.yaml

I swapped out the default being pydantic 1 to pydantic 2, since 1 is soon to be deprecated, and also added testing for 3.11

dynamic versioning

This PR ALSO adds dynamic versioning to this repo exactly as is done in linkml - i am not sure why that wasn't present before, but it seems like it should be? currently the version in the repo is literally 0.0.0 and that prevents us from checking that the correct linkml-runtime version is installed during this action

don't specify linkml-runtime repository so it works on pull requests
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.70%. Comparing base (ed36311) to head (ea9c1b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   62.70%   62.70%           
=======================================
  Files          63       63           
  Lines        8580     8580           
  Branches     2444     2444           
=======================================
  Hits         5380     5380           
  Misses       2583     2583           
  Partials      617      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit e5d1886 into linkml:main Apr 2, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants