Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(converters): add option include descendants #1630

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(converters): add option include descendants #1630

wants to merge 3 commits into from

Commits on Sep 21, 2023

  1. feat(converters): add option include descendants 

    "gen-json-schema" and "linkml-validate" have the option
"--include-range-class-descendants" so that children of a class
specified in a range are added to the generated JSON-Schema as allowed
classes.

This patch adds a similar option to "linkml-convert", with the same
result in the JSON-Schema being used for validation as the equally named
option for "gen-json-schema" and "linkml-validate".

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
    @Silvanoc
    Silvanoc committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    cd021ee View commit details
    Browse the repository at this point in the history

  2. test(converters): add tests 

    Extend "linkml-convert" tests to cover the new option
"--include-range-class-descendants".

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
    @Silvanoc
    Silvanoc committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    848810a View commit details
    Browse the repository at this point in the history

  3. fix(converter): fix validation 

    Apply same validation code as in 'linkml-validate' to include range
class descendants.

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
    @Silvanoc
    Silvanoc committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    59197b1 View commit details
    Browse the repository at this point in the history