rmv unnecessary default_factories #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
commented
Feb 12, 2024
tests/test_biolink_model/output/biolink-model.model.context.jsonld
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 100 100
Lines 11500 11500
Branches 2968 2902 -66
=======================================
Hits 9206 9206
Misses 1738 1738
Partials 556 556 ☔ View full report in Codecov by Sentry. |
cmungall
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Much cleaner, thanks.
Btw, looks like you accidentally committed 2 /output/ files. These are annoying vestige we need to get rid of. Mostly it's harmless to commit these changes but it could lead to spurious conflicts. See https://linkml.io/linkml/contributing/contributing.html#general-tips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the pattern
field(default_factory=lambda: X)makes sense if you have a mutable field, a field that requires substantial computation, or a field where the assignment needs to be delayed until after the definition of the class. In the case where X is simply a bool, an int, or a string, I don't think this does anything for you and can safely be removed. Is there a reason to have this that I am missing?