Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for empty preconditions in rules. #1926

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Adding tests for empty preconditions in rules. #1926

merged 3 commits into from
Feb 15, 2024

Conversation

cmungall
Copy link
Member

Made jsonschema and owl consistent in their interpretation of this

Made jsonschema and owl consistent in their interpretation of this
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (55cc87f) 80.13% compared to head (c88d381) 80.16%.
Report is 4 commits behind head on main.

Files Patch % Lines
linkml/generators/owlgen.py 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1926      +/-   ##
==========================================
+ Coverage   80.13%   80.16%   +0.03%     
==========================================
  Files         100      100              
  Lines       11503    11531      +28     
  Branches     2903     2912       +9     
==========================================
+ Hits         9218     9244      +26     
- Misses       1732     1740       +8     
+ Partials      553      547       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall linked an issue Feb 15, 2024 that may be closed by this pull request
@cmungall cmungall merged commit e90d956 into main Feb 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define behavior if rules when preconditions are empty
1 participant