Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize rendering of Applicable classes section on slot documentation pages #2009

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

sujaypatil96
Copy link
Member

Optimize the rendering of Applicable classes section on slot documentation pages.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (9055382) to head (f489d5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files         107      107           
  Lines       11921    11921           
  Branches     3409     3409           
=======================================
  Hits         9617     9617           
  Misses       1741     1741           
  Partials      563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to include poetry.lock?

@sujaypatil96
Copy link
Member Author

Yup, I did. We need the changes from the latest release of linkml-runtime v1.7.4 for the update in this PR to work.

@sujaypatil96
Copy link
Member Author

Thanks for the feedback @cmungall! I updated the PR to include/enforce the dependency requirement in pyproject.toml.

@sujaypatil96
Copy link
Member Author

I needed to make commit 78364a4 because there were merge conflicts on this PR after #2002

@cmungall
Copy link
Member

can you resolve the conflicts?

@sujaypatil96
Copy link
Member Author

Done!

@cmungall cmungall merged commit f5076a6 into main Mar 27, 2024
17 checks passed
@sujaypatil96 sujaypatil96 deleted the optimize-slot-jinja branch April 26, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants