Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically PR to update poetry lockfile v2 #2028

Merged
merged 23 commits into from
Mar 26, 2024

Conversation

sneakers-the-rat
Copy link
Collaborator

Fixes: #2023

Sorry for the commit spray here - i would suggest doing a squash merge on this one. debugging stuff on CI is always so tedious.

on the maiden voyage of the lockfile updater, it became clear that something was amiss in the generated PR (there was nothing in it). serves me right for drawing from a gh action with like 5 usages.

now presenting, the new and improved version

  • turns out you need to install the package before calling update, or else it just installs all the current versions without saying "updating" anywhere.
  • you also need to specify bash as the shell explicitly, bc sh doesn't like stuff like "multiline strings"
  • you also need to use this fancy multiline string syntax to store the variable
  • and finally, you also seem to need to store it in $GITHUB_ENV rather than $GITHUB_OUTPUT despite what the docs say

i have confirmed that this works now on my own fork: sneakers-the-rat#4

thank you for bearing with me on this day where i was especially extra obnoxious

@sneakers-the-rat sneakers-the-rat added the devops poetry, setuptools, actions, etc. related changes label Mar 26, 2024
@sneakers-the-rat sneakers-the-rat changed the title Actions poetry update Automatically PR to update poetry lockfile v2 Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (aa75b4b) to head (33523b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2028   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files         104      104           
  Lines       11624    11624           
  Branches     2909     2909           
=======================================
  Hits         9379     9379           
  Misses       1701     1701           
  Partials      544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit 9055382 into linkml:main Mar 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops poetry, setuptools, actions, etc. related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants