Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to "inlining" documentation #2039

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix link to "inlining" documentation #2039

merged 2 commits into from
Mar 29, 2024

Conversation

nlharris
Copy link
Contributor

fixes #2030

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (f5076a6) to head (86941f1).
Report is 1 commits behind head on main.

❗ Current head 86941f1 differs from pull request most recent head 5e9be1b. Consider uploading reports for the commit 5e9be1b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2039   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files         107      107           
  Lines       11921    11921           
  Branches     3409     3409           
=======================================
  Hits         9617     9617           
  Misses       1741     1741           
  Partials      563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nlharris
Copy link
Contributor Author

I'm not sure why this failed the tests. I didn't change any code.

@sujaypatil96
Copy link
Member

I re-ran the jobs that didn't go through, the logs were very strange as to why it wasn't going through just for Python 3.9/3.10 on ubuntu.

docs/faq/modeling.md Outdated Show resolved Hide resolved
@sujaypatil96 sujaypatil96 merged commit 8a28750 into main Mar 29, 2024
15 checks passed
@sujaypatil96 sujaypatil96 deleted the nlharris-patch-4 branch March 29, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation needs better discussion of inlining (and link there is broken)
2 participants