Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert enhancements to pytest #2052

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

sneakers-the-rat
Copy link
Collaborator

@sneakers-the-rat sneakers-the-rat commented Apr 5, 2024

Fix: #1718

Other stuff:

  • Make pythongen, generator, rawloader, schemaloader accept Paths, at least nominally so type checkers stop complaining.
  • same with snapshot
  • add marks:
    • no_asserts: for keeping track of the tests that are just print statements, just snapshot comparisons, or otherwise don't make meaningful assertions - we'll want to consolidate these and make sure we have unit tests for all the behavior they test perhaps indirectly
    • strcmp: tests that primarily compare stringified values rather than programmatic values - these are fragile and indirect, break when the string representation of anything changes, and can't use __eq__ of the native object types. we'll also want to progressively clean these up.
  • started making tests xfail rather than skip so we know when we actually fix them/remind ourselves that we intended to turn them back on eventually
  • add xfailing tests for pythongen pattern validation
  • Generator had a log_level param but didn't use it, so i made it use it.

one step closer to not having to dodge outputs!

@sneakers-the-rat sneakers-the-rat added devops poetry, setuptools, actions, etc. related changes chore labels Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.34%. Comparing base (bdabda1) to head (d246a16).

Files Patch % Lines
linkml/utils/rawloader.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2052   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files         107      107           
  Lines       11967    11978   +11     
  Branches     3418     3422    +4     
=======================================
+ Hits         9615     9624    +9     
- Misses       1783     1784    +1     
- Partials      569      570    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmungall cmungall merged commit 4f5e934 into linkml:main Apr 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore devops poetry, setuptools, actions, etc. related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert tests in tests/test_enhancements to pytest
2 participants