Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1718
Other stuff:
Path
s, at least nominally so type checkers stop complaining.snapshot
no_asserts
: for keeping track of the tests that are just print statements, just snapshot comparisons, or otherwise don't make meaningful assertions - we'll want to consolidate these and make sure we have unit tests for all the behavior they test perhaps indirectlystrcmp
: tests that primarily compare stringified values rather than programmatic values - these are fragile and indirect, break when the string representation of anything changes, and can't use__eq__
of the native object types. we'll also want to progressively clean these up.Generator
had alog_level
param but didn't use it, so i made it use it.one step closer to not having to dodge outputs!