plantuml: hide circle and empty members, remove quotes #2060
Conversation
|
Thanks! The corresponding test should be fixed too - let us know if you want one of us to take over from here or if you're able to make the additional change yourself! |
|
@cmungall please take over, thanks!! |
|
Thanks for the changes @VladimirAlexiev!! I'm happy to take over from here. Will keep you posted. |
|
Hi @VladimirAlexiev it looks like certain Actions are not going through because you haven't run the ruff linter on your code. Could you run the below command using ruff: ruff check linkml/generators/plantumlgen.py |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 80.04% 80.04% -0.01%
==========================================
Files 109 109
Lines 12168 12167 -1
Branches 3449 3449
==========================================
- Hits 9740 9739 -1
Misses 1852 1852
Partials 576 576 ☔ View full report in Codecov by Sentry. |
| @@ -129,13 +133,11 @@ def add_class(self, cn: ClassDefinitionName) -> str: | |||
| if True or cn in slot.domain_of: | |||
| mod = self.prop_modifier(cls, slot) | |||
| slot_defs.append( | |||
| ' {field} "' | |||
There was a problem hiding this comment.
I tend to add quotation marks to generated names for robustness: it doesn't harm having them and it won't break if any unexpected whitespaces appear in the names.
@VladimirAlexiev what does it harm to have them? What does it bring to remove them? If it doesn't harm or bring much, why removing them?
I suppose that we can rely on underscore() to ensure that no whitespaces appear in the names. So removing them shouldn't suppose any risk.
There was a problem hiding this comment.
Good questions @Silvanoc! I'd like to know the answer to the question you asked as well -- what are the pros of removing the quotes? @VladimirAlexiev
|
LGTM I have only what is probably a nitpick: #2060 (comment) |
|
lgtm. We can circle back on escaping issues |
No description provided.