Update slot cardinality meaning on main linkml docs site #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
=======================================
Coverage 79.88% 79.88%
=======================================
Files 109 109
Lines 12249 12249
Branches 3489 3489
=======================================
Hits 9785 9785
Misses 1874 1874
Partials 590 590 ☔ View full report in Codecov by Sentry. |
cmungall
requested changes
May 9, 2024
docs/schemas/slots.md
Outdated
|
|
||
| The cardinality of a slot in UML class diagrams indicates the number of instances of one class | ||
| that can be linked to an instance of another class. Cardinality (sometimes also referred to as | ||
| *multiplicity*) notations are placed near the end of an association. |
There was a problem hiding this comment.
"...placed near the end of an association" - did this come from UML documentation. I think this is fine for UML documentation but you need to place it in more context here
There was a problem hiding this comment.
I pieced it together from some UML docs and mermaid docs. But yes, you're right it would be helpful to clarify what "association" means in this context.
cmungall
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the current description shown here: https://linkml.io/linkml/schemas/slots.html#slot-cardinality to capture the latest description of cardinality according to the method definition here: https://github.com/linkml/linkml/blob/main/linkml/generators/docgen.py#L567-L623