genshacl: fix the propagation of types to SHACL sh:datatype and sh:nodeKind
#2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the pervious state, the edited code was never reached. With this change, a linkml or custom type as slot range will propagate to the property's sh:datatype in SHACL. In addition, a nodekind of sh:Literal is added for such properties.
|
🙏 let us know if you want help with the test output. This is failing on the compliance tests. It may be the case that we want to change the test itself. You may find it useful to run this test with |
In b415224 a change was made to add 'sh:nodeKind sh:Literal' to a property shape for a slot with a type as range. This required an update to the expected shacl output used in 'test_compliance/test_core_compliance.py::test_cardinality'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
+ Coverage 79.88% 79.92% +0.04%
==========================================
Files 109 109
Lines 12249 12250 +1
Branches 3489 3489
==========================================
+ Hits 9785 9791 +6
+ Misses 1874 1869 -5
Partials 590 590 ☔ View full report in Codecov by Sentry. |
cmungall
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous state, the edited code was never reached. With this change, a linkml or custom type as slot range will propagate to the property's
sh:datatypein SHACL. In addition, ash:nodekindofsh:Literalis added for such properties (based on my interpretation of this comment)This PR is intended to close #1299. It does pretty much the same as #1300, but that PR has been stagnant for over a year and is based on old state of
main. So I though a fresh PR might be useful to get the fix merged. Happy to close again if the preference would be to rather update the existing PR.TODO: