Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: support charset pass as query string #0000 #4

Conversation

prajapati-kaushik
Copy link
Contributor

@prajapati-kaushik prajapati-kaushik commented Oct 25, 2023

in PDO, you set the MySQL character set in the connection options.
PDO=mysql://root:secret@localhost/example?charset=utf8mb4;


Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

If this relates to a card, please include a link to the card here. Additionally, please terminate the PR title with # and the card number, such as Fix doomsday bug #1234

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types

Please indicate if your PR introduces a breaking change

  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@prajapati-kaushik prajapati-kaushik marked this pull request as ready for review October 25, 2023 09:11
@joostfaassen joostfaassen merged commit 1044dff into linkorb:master Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants