Restructure command init to avoid unit test wonkiness

per spf13/cobra#1599 (comment)
linkous8 · Apr 22, 2024 · cc067eb · cc067eb
1 parent e466597
commit cc067eb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/cmd/optimize/configure.go b/cmd/optimize/configure.go
@@ -52,11 +52,6 @@ var errOptimizerConfigNotFound = errors.New("optimizer config not found")
 var errProfilerMissingData = errors.New("missing data in profiler report")
 var errProfilerInvalidData = errors.New("invalid data found in profiler report")
 
-func init() {
-	// TODO move this logic to optimize root when implementing unit tests
-	optimizeCmd.AddCommand(NewCmdConfigure())
-}
-
 func NewCmdConfigure() *cobra.Command {
 	flags := configureFlags{}
 	configureCmd := &cobra.Command{

diff --git a/cmd/optimize/optimize.go b/cmd/optimize/optimize.go
@@ -29,5 +29,7 @@ via the report subcommand.`,
 }
 
 func NewSubCmd() *cobra.Command {
+	optimizeCmd.AddCommand(NewCmdConfigure())
+
 	return optimizeCmd
 }