This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Allow setting values as string #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of introducing more fields.
This parameter makes the resource use the `--set-string` option of Helm (instead of the `--set` option) for the given value override. It can be used to ensure that Helm always treats the value as a string, useful if the value varies and may look like a number, eg. if it's a Git commit hash. See helm/helm#1707
|
@msiegenthaler could you please release/tag the new Docker image? |
|
Sure, I tagged it and it should be available on dockerhub in a few minutes |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a
type: stringparameter inoverride_values. This parameter makes the resource use the--set-stringoption of Helm (instead of the--setoption) for the given value override. It can be used to ensure that Helm always treats the value as a string, useful if the value varies and may look like a number, eg. if it's a Git commit hash. See also helm/helm#1707