Enhance generating token #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
force-pushed
the
enhance_generate_token
branch
2 times, most recently
from
309ffa1
to
b42912f
Compare
s3b4stian
reviewed
Aug 4, 2018
src/CsrfGuard.php
Outdated
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| namespace Linna; | |||
|
|
|||
| use Ramsey\Uuid\Uuid; | |||
| use Ramsey\Uuid\Exception\UnsatisfiedDependencyException; | |||
There was a problem hiding this comment.
Hi! Thanks for enhancements, these lines of code seems unused inside the class!
There was a problem hiding this comment.
Yes, I forgot to remove that namespace after finishing my experiment.
peter279k
force-pushed
the
enhance_generate_token
branch
from
b42912f
to
3a9906b
Compare
|
Ok! I Merge the pull, and I will insert these changes on the changelog for 1.2 release! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
tokenStrengthbe the16at least.emptyto check whether the requested token is existed.??syntax usage.ifconditions.