Spec for aggregate debug reporting reports generation and delivery #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linnan-github
force-pushed
the
adrReportCreate
branch
2 times, most recently
from
4586d1a
to
824633b
Compare
linnan-github
force-pushed
the
adrReportCreate
branch
from
824633b
to
59ddffd
Compare
linnan-github
force-pushed
the
adrReportCreate
branch
from
64dbeed
to
04c908d
Compare
apasel422
suggested changes
May 28, 2024
| per [=aggregatable debug rate-limit window=]. The second controls the total | ||
| [=aggregatable debug report/required aggregatable budget=] of all [=aggregatable debug reports=] | ||
| with a given ([=aggregatable debug rate-limit record/context site=], [=aggregatable debug rate-limit record/reporting site=]) | ||
| per [=aggregatable debug rate-limit window=]. Its value is (2<sup>20</sup>, 65536). |
There was a problem hiding this comment.
Are we sure that the first value here should be a constant and not a vendor-specific value?
There was a problem hiding this comment.
I think we can keep this as a constant for now to be consistent.
linnan-github
force-pushed
the
adrReportCreate
branch
from
e06a623
to
5dac68c
Compare
apasel422
reviewed
May 31, 2024
| @@ -977,17 +979,23 @@ An attribution trigger is a [=struct=] with the following items: | |||
|
|
|||
| An attribution report is a [=struct=] with the following items: | |||
|
|
|||
| <dl dfn-for="attribution report, aggregatable report, event-level report"> | |||
| <dl dfn-for="attribution report, aggregatable attribution report, event-level report, aggregatable report, aggregatable debug report"> | |||
| : <dfn>reporting origin</dfn> | |||
| :: A [=suitable origin=]. | |||
| : <dfn>report time</dfn> | |||
| :: A [=moment=]. | |||
| : <dfn>report ID</dfn> | |||
There was a problem hiding this comment.
Why do aggregatable debug reports need a report ID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WICG#1289
Introduce aggregatable debug reports and rename aggregatable report to aggregatable attribution reports. Aggregatable report is the base class of aggregatable attribution report and aggregatable debug report.