Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build front-end to pypa/build #18

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Jun 20, 2023

📝 Description

  1. python setup.py build is deprecated. python -m build is the new build frontend for Python projects.
  2. setupext_janitor lacks maintenance.
  3. Migrate file reading function in setup.py to be Path.read_text.

✔️ How to Test

Install and test it with ansible repo's make gendocs

@zliang-akamai zliang-akamai changed the title Zhiwei/setup update Migrate build front-end to pypa/build Jun 20, 2023
@zliang-akamai zliang-akamai requested review from lgarber-akamai and a team June 20, 2023 22:37
Copy link

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected; nice work!

@zliang-akamai zliang-akamai merged commit 6c55a25 into main Jun 22, 2023
6 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/setup-update branch June 22, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants