Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicitly handle None values for E2E testing CA file #435

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

lgarber-akamai
Copy link
Contributor

馃摑 Description

This change resolves an issue that caused cert file resolution errors when the TEST_API_CA environment variable was not exported.

This issue is resolved by explicitly using an empty string if the environment variable is None rather than formatting None as a string.

鉁旓笍 How to Test

unset TEST_API_CA
make test

@lgarber-akamai lgarber-akamai requested a review from a team as a code owner November 6, 2023 15:24
@lgarber-akamai lgarber-akamai requested review from zliang-akamai, vshanthe and jriddle-linode and removed request for a team November 6, 2023 15:24
@lgarber-akamai lgarber-akamai merged commit 15b78af into linode:dev Nov 6, 2023
4 checks passed
zliang-akamai pushed a commit that referenced this pull request Nov 13, 2023
* Bump types-requests from 2.31.0.2 to 2.31.0.10 (#431)

Bumps [types-requests](https://github.com/python/typeshed) from 2.31.0.2 to 2.31.0.10.
- [Commits](https://github.com/python/typeshed/commits)

---
updated-dependencies:
- dependency-name: types-requests
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* make deps upgrade (#432)

* adding vpc fields

* Explicitly handle none values for testing CA (#435)

* merging to fix errors

* adding tests for ip_info

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants