Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one backend obj for all apps #1640

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

srodenhuis
Copy link
Contributor

@srodenhuis srodenhuis commented Jul 8, 2024

This PR aims to make the configuration of Object Storage and Backups more consistent and easier to maintain.

OBJ is now configured in the platform settings. A user can choose between disabled (no OBJ is configured), minioLocal (for PoC/dev use-cases) and Linode (using Linode OBJ service). Integrated applications like Harbor, cnpg, Loki, Tempo and Velero, consume the OBJ configuration and do not need to be configured independently.

With this PR we do not support any other OBJ service. If a user would like to use AWS S3 or Azure Blob, then the user needs to configure this using rawValues per app.

Other changes:

  • Backup schedules for PVs of core apps have been removed
  • Velero now only support Linode cloud. Users can use rawValues to configure other infrastructure/cloud providers to create pv backups and snapshots
  • Linode is now the default cluster.provider. Now there are only 2 providers: linode and custom
  • Linode API key (needed to create volume snapshots) is added to the settings.backup section
  • All OBJ configuration in API and schema has been removed for loki, velero, tempo, harbor and cnpg

NOTE:
There is no option in the velero chart to define an additional env using a secretKeyRef. I made some changes to the chart and will submit a PR to support Linode Velero plugin in Velero Helm chart. See here for more info about the Linode Velero plugin: https://github.com/linode/velero-plugin/tree/main?tab=readme-ov-file

@srodenhuis srodenhuis marked this pull request as draft July 8, 2024 06:20
Copy link

gitguardian bot commented Jul 8, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7237573 Triggered Generic Password 11acedf tests/fixtures/env/secrets.settings.yaml View secret
12853661 Triggered Generic High Entropy Secret 11acedf tests/fixtures/env/apps/secrets.harbor.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@srodenhuis srodenhuis changed the title Sr storage backup refactor feat: Storage and backup refactor with one OBJ config Jul 8, 2024
@srodenhuis srodenhuis changed the title feat: Storage and backup refactor with one OBJ config feat: one backend obj for all apps Jul 8, 2024
@srodenhuis srodenhuis marked this pull request as ready for review July 10, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants