Team jobs

[0-sv]

Inside the scope

See related issue on the right-hand side.
Task(s) (see issue):

• Refactor Job/CronJob chart to enable the spec.enabled flag by default.
• Team jobs basic functionality
  • Teams can enter jobs in jobs.demo.yaml.
  • Add functionality to Helmfile (helmfile-60.teams.yaml).

NOTE: the above mentioned tasks still assume that there still exists a "patternProperties object" of jobs. There will be a separate pull request for the refactoring of that task.

Outside the scope

I went a bit out of scope, I made these changes:

• Modified the naming of 'tasks' to 'jobs'. It didn't make sense to me semantically. They are not 'tasks' by Kubernetes API definition. Note: I changed commands from npm run tasks:keycloak to npm run jobs:keycloak, did I break anything?
• I changed the ordering of the 'if' of isMultitenant and hasKey $team services. The ordering was first like this:

{{- range $teamId, $team := $tc.teams }}
{{- if hasKey $team "services" }}
...
{{- if $v.otomi.isMultitenant }}        
...
{{- end }}
<-- new key over here? E.g. {{- if hasKey $team "jobs" }}
{{- end }}
<-- new key over here?
{{- end }}

In this ordering, you can't add another $team key because you can't place it outside the scope of if hasKey $team "services" and inside the scope of if $v.otomi.isMultitenant simultaneously. Anyhow, I'm not sure if it's supposed to be in the scope of if $v.otomi.isMultitenant, please review.

[0-sv]

Note: in #248 there were still some open discussions.

[Morriz]

2 tiny thingsz

[0-sv]

I performed the following things since we last spoke @Morriz:

• Made sure on the cluster that the secrets would be selected
• Made sure on the cluster that the files will be available if the user specifies a path. It was wise to remove the key and path properties because the projected mountPath will be the full path that the user will see the files at if one looks into the container (together with @j-zimnowoda)
• Merged the master branch with the conf test stuff, it caused some conflicts (together with @rawc0der)

I'm gonna take it easy and upgrade MacOS now. If you give any other comments I will do it on Monday with a clear head.

[0-sv]

So this is ignoring the check right now, for the purpose of finishing the story can we please improve it later?

all done