Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use +and for X-Filter header and support filtering on multiple list entries #476

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

lgarber-akamai
Copy link
Contributor

📝 Description

This change adds support for filtering on multiple entries of the same response list when calling list endpoints. This works by flattening out any parsed list arguments and appending all values to a +and filter.

For example:

linode-cli linodes ls --tags foo --tags bar

This command would previously ignore the first specified tag and only filter on the second tag. With this fix, response rows will be required to have both specified tags.

✔️ How to Test

make testunit

@lgarber-akamai lgarber-akamai requested a review from a team June 20, 2023 14:18
@zliang-akamai zliang-akamai requested a review from a team July 5, 2023 05:52
Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, looks good!

@lgarber-akamai lgarber-akamai merged commit 7018f45 into linode:dev Jul 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants