Add integration tests #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-1
requested review from
jriddle-linode,
lgarber-akamai,
zliang-akamai,
ezilber-akamai-zz and
yec-akamai
ykim-1
force-pushed
the
add-integration-tests
branch
from
a9249fe
to
a1d91a5
Compare
|
Can you fix the lint? |
|
Try |
lgarber-akamai
requested changes
May 10, 2023
lgarber-akamai
requested changes
May 11, 2023
jriddle-linode
approved these changes
May 26, 2023
…integration-tests
lgarber-akamai
requested changes
Jun 5, 2023
Comment on lines
31
to
46
| assert re.search("[a-zA-Z]+", account.first_name) | ||
| assert re.search("[a-zA-Z]+", account.last_name) | ||
| assert re.search( | ||
| "^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$", account.email | ||
| ) | ||
| assert re.search( | ||
| "^(\+\d{1,2}\s)?\(?\d{3}\)?[\s.-]?\d{3}[\s.-]?\d{4}$", account.phone | ||
| ) | ||
| assert re.search("[a-zA-Z0-9]+", account.address_1) | ||
| assert re.search("[a-zA-Z0-9]+", account.address_2) | ||
| assert re.search("[a-zA-Z]+", account.city) | ||
| assert re.search("[a-zA-Z]+", account.state) | ||
| assert re.search("[a-zA-Z]+", account.country) | ||
| assert re.search("[a-zA-Z0-9]+", account.zip) | ||
| if account.tax_id: | ||
| assert re.search("[0-9]+", account.tax_id) |
There was a problem hiding this comment.
Be aware that some account may have these attribute as empty strings...
And we also have test_get_account in test/integration/models/test_account.py?
There was a problem hiding this comment.
Yeah but we are using two different ways to get account details.
E.g.
account = client.account()
account = client.load(Account, account_id)
I updated the regex so it can check empty string as well
lgarber-akamai
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding integration tests - more details at:https://jira.linode.com/browse/TPT-1831
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.