Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinodeClient type annotation in Group class #314

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

zliang-akamai
Copy link
Member

馃摑 Description

Better dev experience with an IDE or text editor with this typing.

@zliang-akamai zliang-akamai requested a review from a team as a code owner August 8, 2023 18:18
@zliang-akamai zliang-akamai marked this pull request as draft August 8, 2023 19:52
@zliang-akamai zliang-akamai marked this pull request as ready for review August 8, 2023 19:57
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@zliang-akamai zliang-akamai requested a review from a team August 10, 2023 14:55
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zliang-akamai zliang-akamai merged commit 620091f into linode:dev Aug 14, 2023
7 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/group-client-typing branch August 14, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants