project: DC-Specific Pricing #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement changes to existing endpoints for DC-specific pricing
new: Add integration test for `region_prices` Type field
yec-akamai
approved these changes
Sep 25, 2023
ykim-1
reviewed
Sep 25, 2023
| """ | ||
| Tests that payments can be retrieved | ||
| """ | ||
| transfer = self.client.account.transfer() |
There was a problem hiding this comment.
Is this function hard to test with integration tests? Other than that tests look good!
There was a problem hiding this comment.
@ykim-1 Yup! The main issue is that this represents account-wide network transfer so it's difficult to reliably test it across multiple accunts.
ykim-1
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
This PR will merge the DC-specific pricing project into the
devbranch.鉁旓笍 How to Test