Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve .readthedocs.yaml config file #382

Merged
merged 3 commits into from Mar 18, 2024
Merged

Improve .readthedocs.yaml config file #382

merged 3 commits into from Mar 18, 2024

Conversation

zliang-akamai
Copy link
Contributor

@zliang-akamai zliang-akamai commented Mar 14, 2024 •
edited

馃摑 Description

  • Use latest stable version of Python and Ubuntu so we won't have to upgrade it in the future.
  • Remove legacy requirements.txt and declare dependencies in pyproject.toml.

鉁旓笍 How to Test

Rendered documentation: https://linode-api4--382.org.readthedocs.build/en/382/
Passing build: https://readthedocs.org/projects/linode-api4/builds/23745965/

@zliang-akamai zliang-akamai requested a review from a team as a code owner March 14, 2024 01:08
@zliang-akamai zliang-akamai requested review from ykim-1, yec-akamai and lgarber-akamai and removed request for a team March 14, 2024 01:08
lgarber-akamai
lgarber-akamai approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the deps!

yec-akamai
yec-akamai approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zliang-akamai zliang-akamai merged commit 49dd2c6 into dev Mar 18, 2024
9 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/improved-readthedocs branch March 18, 2024 16:58
@jriddle-linode jriddle-linode added the documentation for updates to the documentation in the changelog. label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@yec-akamai yec-akamai yec-akamai approved these changes

@ykim-1 ykim-1 Awaiting requested review from ykim-1 ykim-1 is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
documentation for updates to the documentation in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zliang-akamai @lgarber-akamai @yec-akamai @jriddle-linode