Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add site_type to Region #386

Merged
merged 2 commits into from
Apr 1, 2024
Merged

new: Add site_type to Region #386

merged 2 commits into from
Apr 1, 2024

Conversation

yec-akamai
Copy link
Contributor

馃摑 Description

Expose a new field site_type to Region.

鉁旓笍 How to Test

tox
make TEST_CASE=test_get_regions testint

Manual Test:

  1. In a sandbox environment, run the following:
import os

from linode_api4 import LinodeClient

client = LinodeClient(os.getenv("LINODE_TOKEN"))

regions = client.regions()

if len(regions) > 0:
    print(f"Region {regions[0].id} site type: {regions[0].site_type}")
  1. Observe that region site type is in the output.

@yec-akamai yec-akamai requested a review from a team as a code owner March 26, 2024 20:07
@yec-akamai yec-akamai requested review from zliang-akamai and ykim-1 and removed request for a team March 26, 2024 20:07
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me and looks good to me!

@jriddle-linode jriddle-linode added the enhancement issues that request a enhancement label Mar 28, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yec-akamai yec-akamai merged commit 0951c34 into dev Apr 1, 2024
9 checks passed
@yec-akamai yec-akamai deleted the TPT-2768/add-site-type branch April 1, 2024 13:52
@jriddle-linode jriddle-linode added improvement for improvements in existing functionality in the changelog. and removed enhancement issues that request a enhancement labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants