Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor integration test directory structure and improve test command usage #397

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

ykim-1
Copy link
Contributor

@ykim-1 ykim-1 commented Apr 16, 2024

馃摑 Description

This PR aims to refactor test directory structure to improve readability and usage of make commands

Updated test make commands are given below:

make TEST_SUITE=linode_client testint         // Runs tests from `test/integration/linode_client`

make TEST_SUITE=account testint         // Runs tests from `test/integration/models/account`

make TEST_CASE=test_get_domain_record testint        // Runs single test case

鉁旓笍 How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

馃摲 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-1 ykim-1 added the testing for updates to the testing suite in the changelog. label Apr 16, 2024
@ykim-1 ykim-1 requested a review from a team as a code owner April 16, 2024 19:14
@ykim-1 ykim-1 requested review from jriddle-linode and yec-akamai and removed request for a team April 16, 2024 19:14
Copy link
Contributor

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works locally.

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@ykim-1 ykim-1 merged commit a931a60 into linode:dev Apr 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants