Simplified Acctest Command Dispatching Workflow #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
When we created the acctest command workflows, GitHub doesn't support using
GITHUB_TOKENto trigger another workflow but later they added some exception.We used a workaround to generate a token as a GitHub App to trigger an
repository_dispatchevent to trigger the integration test. With the newly added exception, now I believe we can trigger the integration test directly by therepository_dispatchevent triggered by the built-inGITHUB_TOKEN, and we can now remove the action that was used to generate GitHub App token.鉁旓笍 How to Test
Will only be testable in this repo after merging.
Success on my forked repo:
zliang-akamai#2 (comment)