Adding missing GPU field from InstanceType and Instance #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work so far! Can you run both unit and integration test to test the change? You probably need to update the fixture to pass the integration test: |
jriddle-linode
approved these changes
Jul 20, 2023
yec-akamai
approved these changes
Jul 20, 2023
|
Let's run an integration test on GitHub |
|
@amisiorek-akamai Everything looks good! Can you re-write the title of the PR a little bit to include more details, and then I think we are good to merge it. |
amisiorek-akamai
changed the title
amisiorek-akamai
force-pushed
the
add_gpu_field
branch
from
5e1fa5d
to
457f533
Compare
amisiorek-akamai
added a commit
to amisiorek-akamai/linodego
that referenced
this pull request
Jul 20, 2023
fixing verification and merging all commits (linode#347)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Added missing GPU field to InstanceType and Instance.
鉁旓笍 How to Test
Added another line to existing test to check if GPU field was being successfully added to Instance object.