Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New upjet + Api Call counter metrics #35

Merged
merged 6 commits into from
May 28, 2024
Merged

New upjet + Api Call counter metrics #35

merged 6 commits into from
May 28, 2024

Conversation

tchinmai7
Copy link
Collaborator

@tchinmai7 tchinmai7 commented May 24, 2024

Description of your changes

  1. Bump to latest upjet 1.4.0
  2. Introduce a API call counter middleware to count api requests, grouped by URL and method
  3. bump go version to 1.22
  4. Use crossplane/build instead of upbound/build - see Use crossplane/build submodule crossplane-contrib/provider-upjet-aws#1313
  5. Set user-agent for requests to the linode api

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Running this locally, and creating an instance, I see

# HELP linode_api_calls_total Number of API calls to the Linode API
# TYPE linode_api_calls_total counter
linode_api_calls_total{method="GET",url="linode/instances/59257627"} 1
linode_api_calls_total{method="GET",url="linode/instances/59257627/configs"} 1
linode_api_calls_total{method="GET",url="linode/instances/59257627/disks"} 1
linode_api_calls_total{method="GET",url="linode/instances/59257627/ips"} 1

@tchinmai7 tchinmai7 merged commit f8b1cff into main May 28, 2024
6 checks passed
@tchinmai7 tchinmai7 deleted the new-upjet-build branch May 28, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants