Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated message for embedded config and disk in linode_instance; remove depguard linter #1019

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Deprecated message for embedded config and disk in linode_instance; remove depguard linter #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89dc804
Add deprecated message to embedded config and disk
zliang-akamai Sep 13, 2023
b8dde38
Remove unwanted linter
zliang-akamai Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ linters:
- gocritic
- scopelint

# Not useful because we widely use open-source dependencies.
- depguard

# These ignores have been added to maintain compatibility with the existing codebase.
# These issues should be resolved at a later date.
- wrapcheck
Expand Down
9 changes: 7 additions & 2 deletions linode/instance/schema_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,10 @@ var resourceSchema = map[string]*schema.Schema{
Elem: resourceConfigInterface(),
},
"config": {
Optional: true,
Computed: true,
Optional: true,
Computed: true,
Deprecated: "The embedded config is deprecated and scheduled to be removed in the next major version." +
"Please consider migrating it to linode_instance_config resource.",
Description: "Configuration profiles define the VM settings and boot behavior of the Linode Instance.",
Type: schema.TypeList,
ConflictsWith: []string{
Expand Down Expand Up @@ -642,6 +644,9 @@ var resourceSchema = map[string]*schema.Schema{
"image", "root_pass", "authorized_keys", "authorized_users", "swap_size",
"backup_id", "stackscript_id", "interface",
},
Deprecated: "The embedded disk block in linode_instance resource is deprecated and " +
"scheduled to be removed in the next major version. Please consider migrating " +
"it to be the linode_instance_disk resource.",
Type: schema.TypeList,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
Expand Down