Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Refactor RUN_LONG_TESTS system; skip all DBaaS tests #1128

Merged
merged 1 commit into from
Nov 9, 2023
Merged

test: Refactor RUN_LONG_TESTS system; skip all DBaaS tests #1128

merged 1 commit into from
Nov 9, 2023

Conversation

lgarber-akamai
Copy link
Contributor

馃摑 Description

This change refactors the RUN_LONG_TESTS logic into a single helper function that can be called at the beginning of tests. Additionally, this PR disables all tests that provision a Managed Database unless RUN_LONG_TESTS is set to true.

鉁旓笍 How to Test

make PKG_NAME=linode/databaseaccesscontrols testacc
make PKG_NAME=linode/databasebackups testacc
make PKG_NAME=linode/databaseengines testacc
make PKG_NAME=linode/databasemysql testacc
make PKG_NAME=linode/databasemysqlbackups testacc
make PKG_NAME=linode/databasepostgresql testacc
make PKG_NAME=linode/databases testacc

For each of these test commands, observe that all database-provisioning tests are skipped.

@lgarber-akamai lgarber-akamai requested a review from a team as a code owner November 8, 2023 20:54
@lgarber-akamai lgarber-akamai requested review from amisiorek-akamai and vshanthe and removed request for a team November 8, 2023 20:54
amisiorek-akamai
amisiorek-akamai approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@amisiorek-akamai amisiorek-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally on my end!

@lgarber-akamai lgarber-akamai merged commit 9a789e2 into linode:dev Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisiorek-akamai amisiorek-akamai amisiorek-akamai approved these changes

@vshanthe vshanthe vshanthe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgarber-akamai @amisiorek-akamai @vshanthe