Added linode_account_settings resource
#760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
lgarber-akamai,
jriddle-linode and
zliang-akamai
jriddle-linode
approved these changes
Feb 9, 2023
lgarber-akamai
requested changes
Feb 10, 2023
| resource.TestCheckResourceAttr(resourceName, "longview_subscription", updatedLongviewPlan), | ||
| resource.TestCheckResourceAttr(resourceName, "backups_enabled", strconv.FormatBool(updatedBackupsEnabled)), | ||
| resource.TestCheckResourceAttr(resourceName, "network_helper", strconv.FormatBool(updatedNetworkHelper)), | ||
| ), |
There was a problem hiding this comment.
We might want an additional test step here to revert settings back to their original settings.
e.g.
tmpl.Updates(t, currLongviewPlan, currBackupsEnabled, currNetworkHelper)
There was a problem hiding this comment.
Good idea! Should I test that the second update went through successfully afterwards or is it fine to just run the update?
There was a problem hiding this comment.
Probably good to validate the results just in case 馃憤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Added a
linode_account_settingsresource to allow users to modify their account settings through the terraform provider.