Added linode_regions datasource and updated linode_region datasource #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/acctest sha=e623f31c4b1aa4c7e33345a1eec710b379787fcb pkg=linode/region |
|
/acctest sha=e623f31c4b1aa4c7e33345a1eec710b379787fcb pkg=linode/regions |
ezilber-akamai
requested review from
lgarber-akamai,
jriddle-linode and
zliang-akamai
jriddle-linode
approved these changes
Feb 14, 2023
| } | ||
| } | ||
|
|
||
| func LoopThroughStringList(resName, path string, listValidateFunc ListAttrValidateFunc) resource.TestCheckFunc { |
There was a problem hiding this comment.
I was thinking about this naming a bit, maybe we could name it something like ValidateResourceAttrList?
Comment on lines
+48
to
+57
| // func flattenRegionResolvers(data interface{}) map[string]interface{} { | ||
| // t := data.(linodego.RegionResolvers) | ||
|
|
||
| // result := make(map[string]interface{}) | ||
|
|
||
| // result["ipv4"] = t.IPv4 | ||
| // result["ipv6"] = t.IPv4 | ||
|
|
||
| // return result | ||
| // } |
There was a problem hiding this comment.
I think we can drop this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added a datasource for the
Regions Listapi endpoint and updated the datasource for theRegion Viewapi endpoint to support new fields.