fix: Make login-related tests opt-in #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/acctest sha=32ce3165a4917b52d5d3bfccc9126e4592419314 pkg=linode/accountlogins |
|
/acctest sha=2684317654e1df6740d607f87e530eed53c5a55d pkg=linode/accountlogins |
lgarber-akamai
changed the title
ezilber-akamai
approved these changes
Mar 8, 2023
jriddle-linode
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
This change makes the login-related tests opt-in. This is necessary as this endpoint only returns logins within the past 90 days and we cannot guarantee that our automated testing account always meets this condition.
Additionally, this change adds error handling when listing logins in test cases.
鉁旓笍 How to Test