Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object storage bucket data source #780

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Add object storage bucket data source #780

merged 4 commits into from
Mar 24, 2023

Conversation

yec-akamai
Copy link
Contributor

馃摑 Description

Add the data source for object storage bucket. Users can get info of a bucket using the data source.

Note: There was an existing data_basic, and a DataBasic func under this objbucket, which are not for getting the actual data source. To avoid misleading, rename and move them to be cluster_data_basic and ClusterDataBasic func.

鉁旓笍 How to Test

make PKG_NAME="linode/objbucket" TESTARGS="-run TestAccDataSourceBucket_basic" testacc

=== RUN   TestAccDataSourceBucket_basic
=== PAUSE TestAccDataSourceBucket_basic
=== CONT  TestAccDataSourceBucket_basic
--- PASS: TestAccDataSourceBucket_basic (12.42s)
PASS
ok  	github.com/linode/terraform-provider-linode/linode/objbucket	13.463s

@yec-akamai yec-akamai force-pushed the TPT-1799/add-objbucket-data-source branch from 3a064fd to d149961 Compare March 21, 2023 19:17
@yec-akamai yec-akamai force-pushed the TPT-1799/add-objbucket-data-source branch from d149961 to d31116a Compare March 21, 2023 19:21
@yec-akamai
Copy link
Contributor Author

/acctest c25cdf3 pkg=linode/objbucket

@yec-akamai
Copy link
Contributor Author

/acctest sha=c25cdf333312610efee9a2aca6fb0ed1a53ff8a7 pkg=linode/objbucket

@yec-akamai yec-akamai requested a review from a team March 21, 2023 19:44
ezilber-akamai
ezilber-akamai approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Tests pass locally.

@yec-akamai yec-akamai merged commit 4d708aa into dev Mar 24, 2023
@yec-akamai yec-akamai deleted the TPT-1799/add-objbucket-data-source branch March 24, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yec-akamai @jriddle-linode @ezilber-akamai