Handle defaults in config function #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/acctest sha=7b8971dddb56ff4c4688e2822d68c91bcb31f5ad pkg=linode/... |
yec-akamai
reviewed
Apr 12, 2023
yec-akamai
approved these changes
Apr 12, 2023
|
/acctest sha=b5361480e428b4f7550876b2fa5f676f5e0eb333 pkg=linode/... |
|
/acctest sha=ee2212c04fb39a99d9cc1f1ec21bbcd8baf903a5 pkg=linode/... |
zliang-akamai
deleted the
zhiwei/sdkv2-provider-handle-default-in-config-func
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is necessary because the Terraform Framework dropped the support of default fields in the schema. And in order to use muxing server with both SDKv2 provider and framework provider, it is required that usage of default fields in SDKv2 provider to be moved to config function.
Issue reported and solved in HashiCorp's repo:
hashicorp/terraform-plugin-framework#640
I separated this change from the main migration branch to make the review of this PR easier. Other migration stuff will be coming in another PR after merging of this one.
✔️ How to Test
make testacc