Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure AD Support (SqlConnection.AccessToken) #1604

Closed
ghost opened this issue Feb 12, 2019 · 3 comments
Closed

Azure AD Support (SqlConnection.AccessToken) #1604

ghost opened this issue Feb 12, 2019 · 3 comments
Assignees
@GonzoSpire
Labels
status: has-pr There is active PR for issue type: feature
Milestone
2.7.0

Comments

@ghost
Copy link

ghost commented Feb 12, 2019

Please could you add support for using Azure AD authentication by allowing the setting of the SqlConnection.AccessToken property before the connection is opened.

The easiest way may be to just have a protected virtual method like BeforeOpen() which is called before the connection is first opened. One could then just override that method to request and set the access token.

linq2db/Source/LinqToDB/Data/DataConnection.cs

Line 968 in 1c234c0

_connection.Open();

@MaceWindu MaceWindu added this to the 2.7.0 milestone Feb 12, 2019
@MaceWindu
Copy link
Contributor

I think you can try to use DataConnection constructor with connectionFactory parameter as workaround for now.

@ghost
Copy link
Author

ghost commented Feb 12, 2019

Does the trick, thanks!

@GonzoSpire GonzoSpire pinned this issue Feb 13, 2019
@GonzoSpire GonzoSpire unpinned this issue Feb 13, 2019
GonzoSpire added a commit that referenced this issue Feb 14, 2019
@GonzoSpire
Add Event OnBeforeConnectionOpen & OnBeforeConnectionOpenAsync
c531589 
fix and tests for issue #1604
@GonzoSpire GonzoSpire mentioned this issue Feb 14, 2019
Merged
@MaceWindu MaceWindu added status: has-pr There is active PR for issue and removed provider: mssql labels Feb 14, 2019
MaceWindu pushed a commit that referenced this issue Feb 16, 2019
@GonzoSpire @MaceWindu
Add Event OnBeforeConnectionOpen & OnBeforeConnectionOpenAsync (#1607)
e667b3c 
* Add Event  OnBeforeConnectionOpen & OnBeforeConnectionOpenAsync

fix and tests for issue #1604

* fix tests and help
@MaceWindu
Copy link
Contributor

#3939 adds new option to do it without custom connection factory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GonzoSpire GonzoSpire

Labels
status: has-pr There is active PR for issue type: feature
Milestone
2.7.0
Development

No branches or pull requests
2 participants
@MaceWindu @GonzoSpire