Correct DeleteWithOutputAsync() function name #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, looks like we do not have regression test for this function ;) |
|
pish posh. 😁 |
|
And missed again. Tested on Sync version. |
|
Yes, all of the tests were only done w/ the sync version. Only added sync to match the other sync tests. I can double all of the tests for the async versions if you want? Seems somewhat extraneous, but... |
|
Believe me it worth efforts. We can accidentally change something and async versions may fail. |
|
PS: Blame @MaceWindu - he's the one who wrote the InsertWithOutput tests that I copied from originally... 😉 |
|
It's me ;) Really messed up with count of new methods. |
|
There. Punk... :) |
|
/azp run test-all |
sdanyliv
approved these changes
Apr 22, 2021
|
Azure Pipelines successfully started running 1 pipeline(s). |
MaceWindu
requested changes
Apr 23, 2021
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
MaceWindu
approved these changes
Apr 23, 2021
MaceWindu
pushed a commit
to linq2db/linq2db.baselines
that referenced
this pull request
Apr 23, 2021
* [Windows / NET472 / SQL Server 2019 (Microsoft.Data.SqlClient)] baselines * [Windows / NET472 / SQL Server 2008 (System.Data.SqlClient)] baselines * [Windows / NET472 / SQL Server 2017 (System.Data.SqlClient)] baselines * [Windows / NET472 / SQL Server 2014 (System.Data.SqlClient)] baselines * [Windows / NET472 / SQL Server 2012 (System.Data.SqlClient)] baselines * [Windows / NETCOREAPP2.1 / SQL Server 2012 (System.Data.SqlClient)] baselines * [Windows / NETCOREAPP2.1 / SQL Server 2014 (System.Data.SqlClient)] baselines * [Linux / NET5.0 / SQL Server 2019 (Microsoft.Data.SqlClient)] baselines * [Windows / NET 5.0 / SQL Server 2019 (Microsoft.Data.SqlClient)] baselines * [Windows / NETCOREAPP2.1 / SQL Server 2016 (System.Data.SqlClient)] baselines * [Windows / NETCOREAPP2.1 / SQL Server 2008 (System.Data.SqlClient)] baselines * [Windows / NETCOREAPP2.1 / SQL Server 2017 (System.Data.SqlClient)] baselines * [Windows / NET472 / SQL Server 2016 (System.Data.SqlClient)] baselines Co-authored-by: Azure Pipelines Bot <azp@linq2db.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.