Fix System.Data.Linq.Binary performance

[guillaume86]

While benchmarking linq2db on the Northwind sample database vs Linq2SQL (a netcore port with some little fixes), I got disappointing results on some tables, and after investigation, I found the System.Data.Linq.Binary was the issue:

The Binary constructor eagearly computes the hash:

linq2db/Source/LinqToDB/Compatibility/System/Data/Linq/Binary.cs

Line 28 in 1796892

ComputeHash();

which is just wasted cycles if you don't end up using it. The class will compute the hash lazily when needed so it can safely be removed from the constructor if I'm not mistaken.

[MaceWindu]

Why do you need Binary type?

[guillaume86]

I'm migrating a codebase from Linq2SQL, I will use the same entities for both linq2sql and linq2db for a while. Le lun. 30 janv. 2023 à 11:06, MaceWindu ***@***.***> a écrit :

…

Why do you need Binary type? — Reply to this email directly, view it on GitHub <#3943 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADL36SRRM56W6SDP6NG5HLWU6HBVANCNFSM6AAAAAAUKQ6TZI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[MaceWindu]

PR is welcome. Should be easy fix. BTW, it copies netfx behavior, but of course we can improve it

[guillaume86]

Thanks, will do. Yes I noticed it was original behavior, it was the netcore port I used as a baseline (https://github.com/mindbox-moscow/data-linq/blob/main/Mindbox.Data.Linq/Binary.cs) that had fixed it, probably because they noticed the same thing.