Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .net core 2.1 support #3441

Merged
merged 65 commits into from Mar 1, 2022
Merged

remove .net core 2.1 support #3441

merged 65 commits into from Mar 1, 2022

Conversation

MaceWindu
Copy link
Contributor

@MaceWindu MaceWindu commented Feb 22, 2022

  • removed explicit .net core 2.1 support (users still can use linq2db there with netstandard2.0 builds). 2.1 reached EOL last year and it became a PITA to support builds with tooling changes
  • cleanup dependencies, drop testing of some very old versions of providers
  • cleanup/fix incorrect #if-defs
  • added async version of DisposeCommand method to fix detected sync-over-async cases
  • update ExecuteScope method to support async to fix detected sync-over-async cases
  • switch to System.Text.Json in tests from newtownsoft.json
  • removed PostgreSQL 9 from CI testing
  • removed windows-2016 image use as it will be removed soon from Azure. No SQL Server NETFX tests for now as we don't have suitable docker images repelacement images found!

Remaining tasks:

  • Ensure CI testing still works
    • Access
    • DB2
    • Firebird
    • Informix
    • MySQL/MariaDB
    • Oracle
    • PostgreSQL
    • SAP HANA 2
    • SQL CE
    • SQLite
    • SQL Server
    • Sybase ASE
  • remove windows-2019 image test workflow
  • execute all TFM tests on single db instance to save time on test-runner and db setup for each TFM

PostgreSQL 9 support removal will go in separate PR if approved.

@MaceWindu MaceWindu added this to the 4.0.0-preview.11 milestone Feb 22, 2022
…eapp2.1

# Conflicts:
#	Source/LinqToDB/Data/CommandInfo.cs
#	Tests/Linq/Data/MiniProfilerTests.cs
Copy link
Contributor

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not approving since draft

@viceroypenguin
Copy link
Contributor

Update CONTRIBUTING.md to remove references to netcoreapp2.1 and related defines

@MaceWindu
Copy link
Contributor Author

Which references? I don't see any left

@viceroypenguin
Copy link
Contributor

Weird, when I looked earlier, only 7 files changed, and CONTRIBUTING was not one fo them. I'll re-read now that GH is showing all of the files... /sigh

- remove windows 2016 from CI
- fix sqlite runtime load in netfx tests
@MaceWindu
Copy link
Contributor Author

/azp run test-sqlite

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…eapp2.1

# Conflicts:
#	Build/Azure/pipelines/templates/test-jobs.yml
#	Tests/FSharp/Tests.FSharp.fsproj
@MaceWindu
Copy link
Contributor Author

/azp run test-sqlite

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-sqlite

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu MaceWindu marked this pull request as ready for review February 22, 2022 16:02
@MaceWindu
Copy link
Contributor Author

I still need to fix CI testing, but otherwise it is ready for review

@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu MaceWindu merged commit 3fda6da into dev.v4 Mar 1, 2022
MaceWindu pushed a commit to linq2db/linq2db.baselines that referenced this pull request Mar 1, 2022
* [Windows / SQL Server EXTRAS] baselines

* [Linux / SQL Server 2019] baselines

* [Windows / Access ACE (OLEDB/ODBC) x64] baselines

* [Linux / DB2 LUW 11.5] baselines

* [Linux / DB2 LUW 11.5] baselines

* [Windows / SQL Server EXTRAS] baselines

* [Windows / SQLite (specialized tests)] baselines

* [Linux / SQL Server 2019] baselines

* [Windows / SQL Server 2012] baselines

* [Windows / SQL Server 2005] baselines

* [Windows / SQL Server 2017] baselines

* [Windows / SQL Server 2016] baselines

* [Windows / SQL Server EXTRAS] baselines

* [Windows / SQL Server 2019] baselines

Co-authored-by: Azure Pipelines Bot <azp@linq2db.com>
@MaceWindu MaceWindu deleted the infra/remove_netcoreapp2.1 branch March 1, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants