-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(url): fix url encoding issue #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 73.81% 77.61% +3.79%
==========================================
Files 9 9
Lines 802 804 +2
==========================================
+ Hits 592 624 +32
+ Misses 210 180 -30 ☔ View full report in Codecov by Sentry. |
bc4498e
to
c17d2b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #224 .
I add an example that a file path contains multiple whitespaces here:
gitlinker.nvim/minimal_init/test cases/this is a file contains whitespaces.txt
Line 1 in 4ce2bd4
The thing is:
GitLink!
) in browser, the browser (for my, it's google chrome) will auto encode the url into URI format, so it's still working for a browser.Regression Test
Platforms
Hosts
Functions
GitLink(!)
to copy git link (or open in browser).GitLink(!) blame
to copy the/blame
link (or open in browser).GitLink(!) default_branch
to open the/main
//master
link in browser (or open in browser).GitLink(!) current_branch
to open the current branch link in browser (or open in browser).