Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LspProgress): retrieve data directly from 'LspProgress' event #144

Merged
merged 1 commit into from
May 20, 2024

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented May 20, 2024

In previous implementation: #137 , I used to poll the LSP status data from lsp clients, I learned it the Neovim's documents:

  1. lsp - LspProgress
  2. lsp - vim.lsp.Client.Progress

They should be officially supported, but I found it's difficult to understand the vim.lsp.Client.Progress data structure, the doc says it's extended from the RingBuf, so I simply used the pop API from the ringbuf, but my eyes feel like something are missing.

So this PR will directly retrieve the data from the LspProgress event data, it looks much better actually.

@linrongbin16 linrongbin16 changed the title refactor(LspProgress): retrieve data directly from 'LspProgress' event fix(LspProgress): retrieve data directly from 'LspProgress' event May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.99%. Comparing base (07ca8ea) to head (2f9400e).

Files Patch % Lines
lua/lsp-progress.lua 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   72.50%   72.99%   +0.48%     
==========================================
  Files           7        7              
  Lines         451      448       -3     
==========================================
  Hits          327      327              
+ Misses        124      121       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit 55a0489 into main May 20, 2024
9 checks passed
@linrongbin16 linrongbin16 deleted the refactor-lspprogress branch May 20, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant