"kernel module 'acpi_call' load error" on Thinkpad T490 with Ubuntu 18.04

[jerabaul29]

This is a bug report opened following recommendation form the discussion here: https://askubuntu.com/questions/1166885/protect-battery-on-thinkpad-t490-ubuntu-18-04 .

Description / to reproduce

On Ubuntu 18.04, with a thinkpad T490, 'usual' Ubuntu install:

~$ sudo tlp setcharge START_CHARGE 70
Error: ThinkPad battery features not available.

I think this is due to problems with tp-sampi and / or tpacpi-bat:

~$ sudo tlp stat
...
+++ ThinkPad Battery Features
tp-smapi   = inactive (kernel module 'tp_smapi' load error)
tpacpi-bat = inactive (kernel module 'acpi_call' load error)

Expected behavior

All I want is protect my battery ie let it rest between 70 and 80 percents when on external power supply, so i want to be able to set the _CHARGE parameters.

Output tlp:

see:

https://gist.github.com/jerabaul29/c7f57a8e0d83a648e918541aef49d802

[linrunner]

Hi,

please read the Issue template and the Bug Reporting Howto before actually submitting an issue and give all information required by the template.

You'll find suggestions für module "load error" in the FAQ. In your case I guess secure boot is the culprit.

This is not an issue with TLP but with Ubuntu's acpi-call-dkms package. Please seek help in adequate forums.

Btw: opening an issue was not suggested at Reddit.

[linrunner]

You're running on kernel 5.0 --> Install TLP 1.2.2 from the PPA and get charge thresholds without the hassle of external kernel modules :-)

[jerabaul29]

Sorry, is it better description? :)

[linrunner]

The problem is not the issue title. Did you actually read what I've written?

[jerabaul29]

Yes, and I am sorry but it was confusing for me which point you wanted some update on / where I was not following the guidelines :) I know very little about those low level things and I must recognize I am a bit afraid of damaging some stuff on my installs.

Thank you for your help. So you mean I should do a:

sudo add-apt-repository ppa:linrunner/tlp
sudo apt-get update 
sudo apt-get upgrade
sudo apt-get install tp-smapi-dkms acpi-call-dkms 

right?

[jerabaul29]

This has worked, many thanks :) Now I get:

~$ sudo tlp-stat
--- TLP 1.2.2 --------------------------------------------

...

+++ Battery Features: Charge Thresholds and Recalibrate
natacpi    = active (data, thresholds)
tpacpi-bat = inactive (kernel module 'acpi_call' load error)
tp-smapi   = inactive (ThinkPad not supported)

...

And I can do:

~$ sudo tlp setcharge START_CHARGE 70
Setting temporary charge thresholds for BAT0:
  stop  =  70

~$ sudo tlp setcharge STOP_CHARGE 80
Setting temporary charge thresholds for BAT0:
  stop  =  80

full output: https://gist.github.com/jerabaul29/62f642ebd79340271e16b1b35c0a02b5

[jerabaul29]

However, as you see this is strange: the START tlp command still seems to set up the stop value. Should I do something else here / open a bug report?

This is also visible here I think:

/sys/class/power_supply/BAT0/charge_start_threshold         =     96 [%]
/sys/class/power_supply/BAT0/charge_stop_threshold          =     70 [%]

[linrunner]

The correct command syntax is

 sudo tlp setcharge 70 80

See the example in the docs. And remember to enter the thresholds into the configuration.

[jerabaul29]

Thanks, I had mis-understood the man page.

[jerabaul29]

FYI @linrunner , I hope now that no other n00bs like me will disturb you :)

https://askubuntu.com/questions/1166885/protect-battery-on-thinkpad-t490-ubuntu-18-04/1167078#1167078

[linrunner]

In your case I guess secure boot is the culprit.

If you want recalibration too, try to disable Secure Boot and the acpi_call module will probably load,

[jerabaul29]

Hmm, I would like to stay away from those Secure Boot parameter changes... Is it a lot I loose if not disabling it? :)

Thank you again for your help :) .