-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot enable autosuspend on USB card reader through USB whitelist #541
Comments
Hi, can you switch to "auto" with powertop? If not, it's a kernel driver or hardware issue. |
Yes, I can - I switched it in |
TLP handles USB devices with the help of udev events. I guess the kernel prevents writing
Reboot and show the trace output:
ps. on my X1C6 here (very similar hardware) with kernel 5.9 the reader device behaves as expected. |
I just remembered, since you use OpenSUSE: #537 Make shure the latest tlp package is installed, otherwise udev events won't work at all. |
Thank you. I put
It switches from battery to AC mode and vice versa just fine, so I think #537 does not affect me. I use TLP 1.3.1 from the latest Tumbleweed package with kernel 5.9.1, so that should be fine. |
The trace reveals no udev events at all. Strange. Are there events in the trace when you (re)plug some USB device like your trackball? I suggest you try to change to USB batch mode by configuring:
Reboot and show the trace again. |
I'm still missing your feedback on the workaround. |
Hi! Sorry for answering late, I had some work to do and it slipped my mind. I've put the line you suggested (
If I do a
|
Note that it works only in batch mode. If I comment out the This persists after a kernel update (I'm on 5.9.14-1 currently) |
I still wonder about the missing udev events at boot without |
No. Here is the
I currently have this in my
Should there be more USB-related output visible? |
There should be a line for every USB plugin event. By now i am quite sure that either you have installed the defective package from #537 or there is something else wrong with your udev installation. Please show:
|
Additional output:
|
I doubt it's the same issue as #537, because AC/BAT is working just fine, and that bug was fixed in the openSUSE repositories in October. But just in case here is the TLP version I'm using:
Here's the
And here's the output from
|
Let's look at the full package contents then:
I would also like to see:
|
Sure. Here are the package contents:
And the content of
|
The install path /usr/lib/udev/tlp-usb-udev is fine. I dissected the .rpm myself and found that 85-tlp.rules and 85-tlp-rdw.rules contain the wrong path:
The problem occurs when the package build calls TLP's Makefile with the TLP_ULIB parameter (tlp.spec Line 77):
This should give TLP_ULIB=/usr/lib/udev but seems to produce /usr/libexec/udev instead. I suggest you file a bug against the openSUSE package. Btw, the same construct works in Fedora's tlp.spec. One more thing to add to your bug report: /usr/share/bash-completion/completions/tlp-rdw is installed by the tlp binary package although it belongs to tlp-rdw. |
Thank you. I've filed bug 1180495 against openSUSE tw for the path in the udev rules, and bug 1180496 for the bash completions in the wrong package. |
Great, let's see. |
openSUSE has a new version of the tlp package (1.3.1-3.1) that shows udev events in the
The card reader is shown with |
Thanks for your feedback. |
Describe the bug
My notebook (Lenovo Thinkpad X1 Yoga 3rd gen) has a built-in Realtek USB3 MicroSD card reader (USB ID
0bda:0328
) that I never use. My system is on OpenSUSE Tumbleweed.TLP reports the card reader as
control=on
. In order to enable autosuspend on the card reader, I have whitelisted it withUSB_WHITELIST="0bda:0328"
in my/etc/tlp.conf
. Nevertheless,tlp-stat
still shows the reader ascontrol=on
.Expected behavior
tlp-stat
should show the reader ascontrol=auto
To Reproduce
The behaviour is the same on AC and battery power.
Steps to reproduce:
USB_WHITELIST="0bda:0328"
in/etc/tlp.conf
tlp-stat
, check for0bda:0328
in the+++ USB
sectionAdditional context
powertop
also reports the card reader, and the (empty)/dev/sdb
device attached to it, as "Bad" with autosuspend disabled.The text was updated successfully, but these errors were encountered: