New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recently-introduced encoding/decoding bugs. #74
Conversation
…er than the Python version.
@kmaglione I don't suppose you might get a chance to rebase this/add the tests mentioned above? :-) |
Ping. There are no versions of python-memcached that work with Python 3 storing bytes. |
Ping on this, it's been open for nearly 2 years. If there's anything I can do to help this get merged please let me know. |
Update – |
The main fix form here is merged in e1f72da. If there are additional issues, feel free to send a new pull request. |
This mainly fixes two encoding/decoding bugs that were introduced since 1.53:
unicode
values are not properly decoded when retrieved on Python 2, andbytes
values are improperly decoded as UTF-8 when retrieved on Python 3.unicode
(e.g.,markupsafe.Markup
) are pickled as plain unicode values, rather than as the derived type.I also ran into quite a lot of issues after I added tests, and tried to run them on Python 3. It seems that a lot of things were broken there, so the final commit which adds tests, also fixes existing test failures.