No output from linter

[vasyas]

I've configured lint-staged with tslint.
tslint is run via npm-run-script:

"scripts": {
      "tslint": "tslint -c tslint.json"
}

"lint-staged": {
    "*.tsx": "tslint",
    "gitDir": "../"
}

When I run tslint directly via Npm, I get linting messages:

~/workspace/ibanking/ui> npm run --silent tslint -- src/common/ModalDialog.tsx
src/common/ModalDialog.tsx[23, 27]: missing whitespace

But when I run it using lint-staged, I get no messages, just the indication of failed process

~/workspace/ibanking/ui> lint-staged
 ❯ Running tasks for *.tsx
   ✖ tslint

🚫 tslint found some errors. Please fix them and try committing again.

Using lint-staged@3.2.6, execa 0.6.0 on MacOS.

[okonet]

Weird. I output both stdout and stderr in case of an error.

[vasyas]

Yes, looks like bug comes from execa.

Btw, it works ok if I use local scripts and fails only for npm run scripts.

[okonet]

Hmm, can it be --silent flag that I'm using when running npm scripts?

https://github.com/okonet/lint-staged/blob/master/src/findBin.js#L16

[grofzero]

I think the problem might be, that execa's cwd is set to the .git directory and not the dir, where package.json is located, but the collected filepaths start from there.

[okonet]

Can you try the latest version since it should fix this behavior I think let me know.

[grofzero]

It's working great! Thank you very much!

[okonet]

👍

[km-tr]

I also get the same error in lint-staged 3.2.8.

[okonet]

@km-tr are you certain? Can you create a repo where I can reproduce this issue?

[km-tr]

It seems that it takes time to reproduce the situation, so I have not finished yet, but I understood the problem part.

If I turn off --silent in findBin.js I got an error like the following.

🚫 lint:js found some errors. Please fix them and try committing again.

npm ERR! Darwin 16.1.0
npm ERR! argv "/Users/kmtr/.anyenv/envs/ndenv/versions/v6.9.1/bin/node" "/Users/kmtr/.anyenv/envs/ndenv/versions/v6.9.1/bin/npm" "run" "lint:js" "--" "/Users/kmtr/dev/assets/javascripts/app/components/App.jsx"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! path /Users/kmtr/dev/package.json
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open '/Users/kmtr/dev/package.json'

npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

gitDir /Users/kmtr/dev
package.jsonDir /Users/kmtr/dev/assets

config.gitDir ../

An error has occurred because it is running in a directory that does not have package.json

[km-tr]

When running execa with runSctipt.js, if res is npm run-script, you did not specify cwd with execaOptions and it worked correctly

[okonet]

I'm still not sure what's the bug exactly. Can anyone create an example with exact steps to r it?

[km-tr]

I have created a repository for testing

https://github.com/km-tr/lint-staged-findbin

If you add js to each stage and run npm run lint-staged you think that you get different results

@okonet

[km-tr]

I was able to confirm that it works correctly at 3.3.0. Thank you very much.