Force process.stdout to be a TTY to support spinners

[iiroj]

No description provided.

[codecov]

Codecov Report

Merging #1163 (8797a9c) into master (32806da) will decrease coverage by 3.05%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##            master    #1163      +/-   ##
===========================================
- Coverage   100.00%   96.94%   -3.06%     
===========================================
  Files           25       26       +1     
  Lines          729      752      +23     
  Branches       197      201       +4     
===========================================
  Hits           729      729              
- Misses           0       20      +20     
- Partials         0        3       +3     

Impacted Files	Coverage Δ
lib/forceTty.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32806da...8797a9c. Read the comment docs.

[dennisjlee]

I tested this PR on Windows and I made several changes in order to make it work: dennisjlee@98d1dbf

@iiroj should I send a PR from my fork?

[iiroj]

@dennisjlee yeah, please do! Try to keep the code async if possible, though. I see you replaced some methods with the sync versions.

[dennisjlee]

@iiroj I tried to keep it async but I ran into some blockers - I'll open the PR and explain there

[dennisjlee]

I sent #1181 as a PR targeting this fix-renderer branch

[Ronsku]

Is this being worked on? This is kind of blocking me from using lint-staged. I appreciate the work you have put down into this! 🌟

Here are some results and info:

• I found this issue from https://stackoverflow.com/questions/72579519/multiple-run-lint-staged-when-use-with-husky
• I have tried with exec >/dev/tty 2>&1 and it works as long as you commit from the terminal, but if you commit from for example VS Code, it doesn't work.

For me it runs crazy many times, this list about 5-10 times longer than what I've screenshot here.

[iiroj]

Hello, the problem was caused by git and fixed (at least for me) by a later git update.

Since I don't have a Windows environment, I haven't put more effort into this.

[dennisjlee]

Is this being worked on? This is kind of blocking me from using lint-staged. I appreciate the work you have put down into this! 🌟

Here are some results and info:

• I found this issue from https://stackoverflow.com/questions/72579519/multiple-run-lint-staged-when-use-with-husky
• I have tried with exec >/dev/tty 2>&1 and it works as long as you commit from the terminal, but if you commit from for example VS Code, it doesn't work.

For me it runs crazy many times, this list about 5-10 times longer than what I've screenshot here.

I had a pending modification to this PR in #1181 but unfortunately I haven't been able to revisit this for a long time.
However, I did try upgrading my Git for Windows to the latest (v2.38.1, from v2.33.0) and that did not resolve the issue for me.

@iiroj if I have time to revisit #1181, would you want me to still land that on top of your fix-renderer branch, or would it make sense to combine #1181 and #1163 into a separate PR?

[iiroj]

@dennisjlee feel free to try out whatever. 👍 Keeping a single PR open is easiest since I have to manually trigger pipelines.

[Ronsku]

Thank you @dennisjlee! I appreaciate it a lot! 😊

[stec00]

Is this PR still being worked on?

[iiroj]

Closing as the original issue should be already be fixed in more recent git versions.