-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps and restore "supports-color" #1264
Conversation
FYI, @okonet |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 735 735
Branches 198 198
=========================================
Hits 735 735
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Ping @okonet I'm getting feedback on the linked issues that restoring |
Originally I migrated to |
I guess let's revert then? |
Maybe not the whole PR but just the color related stuff? |
Yeah I think for now this PR is all we need, since it fixes the detection. 👍 I can clean up the color functions separately later, they're not critical. |
Or actully, let me check quickly if it's a big task to fix the color functions. |
@okonet it was pretty straightforward, so I pushed a commit into this PR. 👍 Looks like
|
Just in case, I opened a new PR in a different branch name than |
Turns out I had permissions to delete the tags and releases! |
This PR updates all dependencies, and also restores
supports-colors
in place ofcolorette
's util, because a commenter mentioned that downgrading lint-staged from 13 to 12 fixed their (Windows) terminal output issues.I figured removal of
supports-color
might be related, since it happened in 13.0.0. The reason behind was to simplify dependencies becauselistr2
uses it internally.I opened this in the
next
branch to get an npm release that people could test.